-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ShowItemUsingFileManager should escape path in Linux #40527
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Congrats on merging your first pull request! 🎉🎉🎉 |
Release Notes Persisted
|
I have automatically backported this PR to "26-x-y", please check out #40560 |
I have automatically backported this PR to "27-x-y", please check out #40561 |
I have automatically backported this PR to "28-x-y", please check out #40562 |
Description of Change
According to https://edeproject.org/spec/file-uri-spec.txt , strings passed to
org.freedesktop.FileManager1.ShowItems
are regarded as escaped file paths:Hence, we should escape the file path passed in before sending it to dbus.
This will fix microsoft/vscode#198045 .
Checklist
npm test
passesRelease Notes
Notes: Fixed file paths passed to
shell.showItemInFolder
not being escaped in Linux.