Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable code cache for custom protocols #40708

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 6, 2023

Backport of #40544

See that PR for details.

Notes: Add an option in protocol.registerSchemesAsPrivileged to allow V8 code cache in custom schemes.

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
@trop trop bot requested a review from a team as a code owner December 6, 2023 02:23
@trop trop bot requested a review from zcbenz December 6, 2023 02:23
@trop trop bot mentioned this pull request Dec 6, 2023
5 tasks
@trop trop bot added 27-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Dec 6, 2023
@ckerr
Copy link
Member

ckerr commented Dec 12, 2023

linux-x64-testing-node failure appears to be a CI flake

not ok 430 parallel/test-cluster-shared-handle-bind-privileged-port # TODO : Fix flaky test
  ---
  duration_ms: 2866.31300
  severity: flaky
  exitcode: 1
  stack: |-
    node:assert:173
      throw err;
      ^
    
    AssertionError [ERR_ASSERTION]: listen should have failed at /home/builduser/project/src/third_party/electron_node/test/parallel/test-cluster-shared-handle-bind-privileged-port.js:50
        at Server.mustNotCall (/home/builduser/project/src/third_party/electron_node/test/common/index.js:530:12)
        at Object.onceWrapper (node:events:628:28)
        at Server.emit (node:events:526:35)
        at emitListeningNT (node:net:1785:10)
        at process.processTicksAndRejections (node:internal/process/task_queues:81:21) {
      generatedMessage: false,
      code: 'ERR_ASSERTION',
      actual: undefined,
      expected: undefined,
      operator: 'fail'
    }
    
    Node.js v18.17.1
    node:assert:126
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    
    1 !== 0
    
        at Worker.<anonymous> (/home/builduser/project/src/third_party/electron_node/test/parallel/test-cluster-shared-handle-bind-privileged-port.js:46:12)
        at Worker.<anonymous> (/home/builduser/project/src/third_party/electron_node/test/common/index.js:452:15)
        at Worker.emit (node:events:514:28)
        at ChildProcess.<anonymous> (node:internal/cluster/primary:187:12)
        at Object.onceWrapper (node:events:629:26)
        at ChildProcess.emit (node:events:514:28)
        at Process.onexit (node:internal/child_process:291:12) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: 1,
      expected: 0,
      operator: 'strictEqual'
    }
    
    Node.js v18.17.1
  ...

@ckerr ckerr merged commit 267cbc8 into 27-x-y Dec 13, 2023
13 checks passed
@ckerr ckerr deleted the trop/27-x-y-bp-feat-enable-code-cache-for-custom-protocols-1701829374642 branch December 13, 2023 18:40
Copy link

release-clerk bot commented Dec 13, 2023

Release Notes Persisted

Add an option in protocol.registerSchemesAsPrivileged to allow V8 code cache in custom schemes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant