perf: use fixed-size arrays for the font cache #40898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we know at compile time which [family x script] combos we want to cache, we can hold the cache in fixed std::arrays instead of in nested std::unordered_maps.
electron-cation
bot
added
new-pr 🌱
codebytere
approved these changes
Jan 8, 2024
codebytere
deleted the
refactor/use-fixed-size-array-for-font-defaults-cache
branch
|
No Release Notes |
|
I have automatically backported this PR to "29-x-y", please check out #40912 |
trop
bot
added
in-flight/29-x-y
merged/29-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
font_defaults.ccholds a private cache of default fonts for [font family, script] combos. The cache is currently implemented with nestedstd::unordered_maps; but since we know at compile time which families and scripts we want to cache, we can hold it in statically-allocated arrays instead.All reviews welcomed. CC @nornagon who originally wrote
font_defaults.ccin #15486 and @dsanders11 who most recently touched the codeChecklist
npm testpassesRelease Notes
Notes: none