Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 2 changes from Release-0-M121 #41105

Merged
merged 2 commits into from Jan 26, 2024

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Jan 24, 2024

electron/security#453 - cc07a95bc309 from chromium Update rendering state of automatic pull nodes before graph rendering

In rare cases, the rendering fan out count of automatic pull node
does not match the main thread fan out count after recreating
a platform destination followed by disconnection.

This CL forces the update of the rendering state of automatic
pull nodes before graph rendering to make sure that fan out counts
are synchronized before executing the audio processing function call.

NOTE: This change makes 2 WPTs fail. The follow-up work is planned
to address them once this patch is merged.

(cherry picked from commit f4bffa09b46c21147431179e1e6dd2b27bc35fbc)

Bug: 1505080
Test: Locally confirmed that ASAN doesn't crash on all repro cases.
Change-Id: I6768cd8bc64525ea9d56a19b9c58439e9cdab9a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5131958
Reviewed-by: Michael Wilson mjwilson@chromium.org
Commit-Queue: Hongchan Choi hongchan@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#1246718}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5214669
Auto-Submit: Hongchan Choi hongchan@chromium.org
Cr-Commit-Position: refs/branch-heads/6099@{#1833}
Cr-Branched-From: e6ee4500f7d6549a9ac1354f8d056da49ef406be-refs/heads/main@{#1217362}

Notes:

  • Security: backported fix for CVE-2024-0807.
  • Security: backported fix for 1407197.

@ppontes ppontes requested a review from a team as a code owner January 24, 2024 21:56
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 28-x-y labels Jan 24, 2024
@ppontes ppontes marked this pull request as draft January 24, 2024 21:58
@ppontes ppontes force-pushed the cherry-pick/security/28-x-y/release-0-m121 branch from 8887634 to a2a6682 Compare January 24, 2024 23:54
@ppontes ppontes changed the title chore: cherry-pick 1 changes from Release-0-M121 chore: cherry-pick 2 changes from Release-0-M121 Jan 24, 2024
@ppontes ppontes marked this pull request as ready for review January 24, 2024 23:57
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patches LGTM.

Looks like this is failing in build-mac on something unrelated; I'll rekick CI and watch to see if it goes green

@ckerr ckerr merged commit 9283a9d into 28-x-y Jan 26, 2024
13 checks passed
@ckerr ckerr deleted the cherry-pick/security/28-x-y/release-0-m121 branch January 26, 2024 15:27
Copy link

release-clerk bot commented Jan 26, 2024

Release Notes Persisted

  • Security: backported fix for CVE-2024-0807.
  • Security: backported fix for 1407197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
28-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants