New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: prefer to inherit observer classes privately #41360
Draft
ckerr
wants to merge
19
commits into
main
Choose a base branch
from
refactor/prefer-to-inherit-observer-classes-privately
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: prefer to inherit observer classes privately #41360
ckerr
wants to merge
19
commits into
main
from
refactor/prefer-to-inherit-observer-classes-privately
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We have a lot of classes that inherit from upstream
FooObserver
classes to manage some state, e.g.AutofillDriverFactory
which inherits fromcontent::WebContentsObserver
so that it can know when to close popups by overridingDidFinishNavigation()
.But since
WebContentsObserver
is 900+ lines long, that public inheritance meansAutofillDriverFactory
exposes a lot of public API to its clients. At best, it's just excess surface area. At worst, clients might accidentally use that API and cause a bug.This PR tries to inherit from upstream
FooObserver
s privately where possible.Checklist
npm test
passesRelease Notes
Notes: none.