chore: fix notes stack updates #41600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlaurencin
changed the title
dsanders11
approved these changes
Mar 14, 2024
ckerr
approved these changes
Mar 15, 2024
Yes, I will work on adding a unit test next |
jkleinsc
requested changes
Mar 21, 2024
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
mlaurencin
force-pushed
the
chore-fix-notes-stack-updates
branch
from
fb2d60b
to
744dad6
Compare
jkleinsc
approved these changes
Apr 29, 2024
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes an issue that would appear when there were multiple Chromium stack upgrades between versions. The notes script did not correctly handle the comparisons needed to determine which stack upgrade superceded which. An example of the previous issue can be seen here: https://github.com/electron/electron/releases/tag/v29.1.1 lists Chromium 122.0.6261.95, however according to https://github.com/electron/electron/blob/v29.1.1/DEPS it's 122.0.6261.111.
Checklist
npm testpassesRelease Notes
Notes: None