fix: Storage.{get|set|clear}Cookies via CDP not working
#41718
Merged
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
enable-browser-context-mgmt
branch
from
3ef2115 to
d74cde7
Compare
codebytere
force-pushed
the
enable-browser-context-mgmt
branch
from
d74cde7 to
a5ee30e
Compare
nornagon
approved these changes
Mar 27, 2024
MarshallOfSound
approved these changes
Mar 27, 2024
nornagon
approved these changes
Mar 28, 2024
|
Test failures are flake; merging. |
|
Release Notes Persisted
|
This was referenced Mar 28, 2024
|
I have automatically backported this PR to "28-x-y", please check out #41738 |
trop
bot
added
in-flight/28-x-y
and removed
target/28-x-y
|
I have automatically backported this PR to "29-x-y", please check out #41739 |
|
I have automatically backported this PR to "30-x-y", please check out #41740 |
trop
bot
added
in-flight/29-x-y
in-flight/30-x-y
merged/30-x-y
trop
bot
added
merged/28-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #41703.
Addresses an issue where calling
Storage.{get|set|clear}Cookiesvia the Chrome Devtools protocol would return the following error:This happened as a result of this logic for Storage handling which relies on a browser context being available via
DevToolsManagerDelegate::GetDefaultBrowserContext(). Chrome's subclasses ofDevToolsManagerDelegateoverride this to return a validBrowserContext, but ours did not until this PR and so it would always be nullptr.We can address this by returning the default
BrowserContextin our subclass. This is modeled after the approach taken byShellDevToolsManagerDelegate::GetDefaultBrowserContext().cc @mxschmitt
Checklist
npm testpassesRelease Notes
Notes: Fixed usage of
Storage.{get|set|clear}Cookiesvia the Chrome DevTools Protocol.