Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fold silent print into settings #41873

Merged
merged 2 commits into from
Apr 17, 2024
Merged

refactor: fold silent print into settings #41873

merged 2 commits into from
Apr 17, 2024

Conversation

codebytere
Copy link
Member

Description of Change

This PR cleans up printing.patch a bit by removing some cruft as well as folding the silent setting into the primary base::Dict holding other settings.

Checklist

Release Notes

Notes: none

@codebytere codebytere requested a review from a team as a code owner April 16, 2024 11:07
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 16, 2024
ckerr
ckerr approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Moving silent into the settings dict makes sense to me and simplifies the patch.

patches/chromium/printing.patch Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 17, 2024
@codebytere codebytere merged commit b118c70 into main Apr 17, 2024
14 checks passed
@codebytere codebytere deleted the printing-cleanup branch April 17, 2024 16:04
@release-clerk Release Clerk
Copy link

release-clerk bot commented Apr 17, 2024

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @ckerr