Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Browser Window Click Event (Issue #24351) #41898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrisssz
Copy link

Description of Change

Added Browser Window Click Events

Checklist

Release Notes

Notes: none

Copy link

welcome bot commented Apr 18, 2024

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 18, 2024
@chrisssz chrisssz changed the title feat: Added Browser Window Click Event feat: Added Browser Window Click Event (Issue #24351) Apr 18, 2024
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please say a little more about your goals here? I see you're trying to address #24351 but this PR has no documentation, no tests, and no end-user API exposure.

At the moment, it also doesn't compile as it's not been fully or correctly implemented. We're happy to try to help resolve the issue, but we can't really proceed with review in this state.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants