Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: data corruption in protocol.handle #41930

Open
wants to merge 2 commits into
base: 29-x-y
Choose a base branch
from
Open

fix: data corruption in protocol.handle #41930

wants to merge 2 commits into from

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 22, 2024

Backport of #41894

See that PR for details.

Notes: Fixed data corruption when protocol.handle() processed incoming data asynchronously.

trop bot and others added 2 commits April 22, 2024 20:40
@trop @nornagon
fix: data corruption in protocol.handle
d280546 
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
@trop @nornagon
slice instead of subarray
cff09fa 
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
@trop trop bot requested review from nornagon and a team April 22, 2024 20:40
@trop trop bot mentioned this pull request Apr 22, 2024
Merged
4 tasks
@trop trop bot added 29-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 22, 2024
jkleinsc
jkleinsc requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newly added test fails with:

Error: dataStream(...) is not a function or its return value is not async iterable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc requested changes

@nornagon nornagon Awaiting requested review from nornagon

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
29-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jkleinsc