fix: requestFullscreen from WebContentsView
#41966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
changed the title
requestFullscreen from WebContentsView
jkleinsc
approved these changes
Apr 29, 2024
|
Release Notes Persisted
|
This was referenced Apr 29, 2024
|
I have automatically backported this PR to "31-x-y", please check out #41995 |
trop
bot
added
in-flight/31-x-y
and removed
target/31-x-y
|
I have automatically backported this PR to "30-x-y", please check out #41996 |
trop
bot
added
in-flight/30-x-y
merged/31-x-y
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #41941.
Fixes an issue where
document.requestFullscreendidn't work when calling it from awebContentsinsideWebContentsView. This was happening because we weren't setting the owner window to the associated NativeWindow after theWebContentsViewwas added to one, and therefore the fullscreen transition wasn't being triggered.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
document.requestFullscreendidn't work when calling it from awebContentsinsideWebContentsView.