fix: recentDocuments on macOS not working #41978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
jkleinsc
approved these changes
Apr 29, 2024
|
Release Notes Persisted
|
This was referenced Apr 29, 2024
|
I have automatically backported this PR to "30-x-y", please check out #41992 |
trop
bot
removed
the
target/30-x-y
|
I have automatically backported this PR to "31-x-y", please check out #41993 |
|
I have automatically backported this PR to "29-x-y", please check out #41994 |
trop
bot
added
in-flight/31-x-y
in-flight/29-x-y
merged/29-x-y
3 tasks
trop
bot
added
merged/30-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #41973.
Fixes an issue where
recentDocumentswasn't populating properly after the ARC migration in bbdd037. This happened because the recent documents member became a member variable instead of a static item as it was previously, meaning it was getting clobbered. This fixes that.Tested with https://gist.github.com/efaca06ece39c8c47ed9b2dae6c3f42e
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
recentDOcumentswasn't populating properly on macOS.