Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry-pick fix thumbnail size patch for macOS #42049

Merged
merged 2 commits into from
May 6, 2024

Conversation

cptpcrd
Copy link
Contributor

@cptpcrd cptpcrd commented May 6, 2024

Description of Change

Cherry-pick https://source.chromium.org/chromium/chromium/src/+/c1f25647c2fcbf5e5a2d574feb284bc7284b944d to fix a regression caused by #41329 where the thumbnails are not captured at the requested resolution. (The patch was made in Chromium 123, so it's already in v30 and just needs to be backported to v29.)

Fixes #41630.

Checklist

Release Notes

Notes: Fixed blurry thumbnails from desktop capturer on macOS.

@cptpcrd cptpcrd requested a review from a team as a code owner May 6, 2024 13:46
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 6, 2024
@codebytere codebytere added backport This is a backport PR backport-check-skip Skip trop's backport validity checking 29-x-y labels May 6, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 6, 2024
@codebytere codebytere added semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels May 6, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 6, 2024
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@VerteDinde VerteDinde changed the title chore: cherry-pick fix thumbnail size patch for macOS fix: cherry-pick fix thumbnail size patch for macOS May 6, 2024
@codebytere codebytere merged commit 8fbabea into electron:29-x-y May 6, 2024
24 checks passed
Copy link

welcome bot commented May 6, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Copy link

release-clerk bot commented May 6, 2024

Release Notes Persisted

Fixed blurry thumbnails from desktop capturer on macOS.

@cptpcrd cptpcrd deleted the blurry-thumbnails-patch branch May 6, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
29-x-y backport This is a backport PR backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants