Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ignore node version mismatch for electron 30 tests #42177

Merged
merged 1 commit into from
May 14, 2024

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented May 14, 2024

Electron 30 CI runs on an older version of node that packager doesn't like, this just bypasses the engine check as it does actually work

Notes: none

@MarshallOfSound MarshallOfSound added backport-check-skip Skip trop's backport validity checking no-backport semver/none labels May 14, 2024
@jkleinsc jkleinsc merged commit 40450d0 into 30-x-y May 14, 2024
21 checks passed
@jkleinsc jkleinsc deleted the fix-packager-old-node branch May 14, 2024 20:02
Copy link

release-clerk bot commented May 14, 2024

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-check-skip Skip trop's backport validity checking no-backport semver/none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants