Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename patches/devtools_frontend to patches/devtools-frontend #42212

Merged
merged 8 commits into from
May 17, 2024

Conversation

appdevopts
Copy link

@appdevopts appdevopts commented May 16, 2024

Remove folder patches/devtools_frontend

Description of Change

Closes #42211.

This PR rename patches/devtools_frontend to patches/devtools-frontend, to resolve conflicts imported by prs:
#40413
#41895
#42103
#42093

There are no test folder in devtools-frontend in this branch, and patches for ChildTargetManager.ts have already been applied by #41895, so the patch #42103 could not be applied!

Checklist

Release Notes

Notes: rename patches/devtools_frontend to patches/devtools-frontend

@appdevopts appdevopts requested a review from a team as a code owner May 16, 2024 16:07
Copy link

welcome bot commented May 16, 2024

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 16, 2024
From patches/devtools_frontend to patches/devtools-frontend
@appdevopts appdevopts changed the title Correct patches/devtools_frontend to patches/devtools-frontend chore: correct patches/devtools_frontend to patches/devtools-frontend May 16, 2024
rename devtools_frontend to devtools-frontend
@appdevopts appdevopts changed the title chore: correct patches/devtools_frontend to patches/devtools-frontend chore: rename patches/devtools_frontend to patches/devtools-frontend May 16, 2024
remove duplicated patch for ChildTargetManager.ts
There are no test folder in devtools-frontend, so this patch can not be applied.
cherry-pick-8a3bfd4b7403.patch
was not valid for this branch
@appdevopts appdevopts changed the title chore: rename patches/devtools_frontend to patches/devtools-frontend fix: rename patches/devtools_frontend to patches/devtools-frontend May 17, 2024
@appdevopts
Copy link
Author

appdevopts commented May 17, 2024

Who can I request to review this PR, or someone could have a look at it?

@VerteDinde @codebytere @jkleinsc

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codebytere codebytere added the backport-check-skip Skip trop's backport validity checking label May 17, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 17, 2024
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label May 17, 2024
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels May 17, 2024
@codebytere
Copy link
Member

@appdevopts we can do a 28 release after this is merged :)

@codebytere codebytere merged commit 65d3530 into electron:28-x-y May 17, 2024
21 checks passed
Copy link

welcome bot commented May 17, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Copy link

release-clerk bot commented May 17, 2024

Release Notes Persisted

rename patches/devtools_frontend to patches/devtools-frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants