Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support upcoming Electron 5.0 with nodeIntegration disabled by default #157

Closed
miniak opened this issue Jan 10, 2019 · 1 comment
Closed

Comments

@miniak
Copy link
Contributor

miniak commented Jan 10, 2019

Electron 5.0 is going to have nodeIntegration disabled by default (electron/electron#16235).

need to replace

mainWindow = new BrowserWindow({width: 800, height: 600})

with

mainWindow = new BrowserWindow({
  width: 800,
  height: 600,
  webPreferences: {
    nodeIntegration: true
  }
})
@malept
Copy link
Member

malept commented Jan 11, 2019

Seems like by default all of the examples should be nodeIntegration = false, and maybe there should be a "Show Me ➡️ Electron APIs ➡️ Node Integration" example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants