Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support upcoming Electron 5.0 with nodeIntegration disabled by default #162

Merged
merged 1 commit into from Jan 21, 2019
Merged

feat: support upcoming Electron 5.0 with nodeIntegration disabled by default #162

merged 1 commit into from Jan 21, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 16, 2019

Fixes #157

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.7% when pulling 2061b26 on miniak/node-integration into 88ce4a7 on master.

@felixrieseberg
Copy link
Member

Thank you!

@felixrieseberg felixrieseberg merged commit c1ae0ec into master Jan 21, 2019
@malept malept deleted the miniak/node-integration branch January 21, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppontes ppontes ppontes approved these changes

@felixrieseberg felixrieseberg Awaiting requested review from felixrieseberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @coveralls @felixrieseberg @ppontes