Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable downloads for Electron below 6.0.8 and 7.0.0 on Windows arm64 #1050

Merged
merged 1 commit into from Apr 24, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Apr 23, 2022

Windows arm64 builds of Electron were only added in v6.0.8 by #20113 and v7.0.0 by #20112
Follow-up to #1019

@miniak miniak force-pushed the disable-download-win-arm64 branch from b305b5d to 0c6a7b9 Compare April 23, 2022 23:06
@miniak miniak changed the title fix: disable downloads for Electron <= 7 on Windows arm64 fix: disable downloads for Electron <6.0.8 or <7.0.0 on Windows arm64 Apr 23, 2022
@miniak miniak force-pushed the disable-download-win-arm64 branch from 0c6a7b9 to 5193dc8 Compare April 23, 2022 23:11
@miniak miniak changed the title fix: disable downloads for Electron <6.0.8 or <7.0.0 on Windows arm64 fix: disable downloads for Electron <6.0.8 and <7.0.0 on Windows arm64 Apr 23, 2022
@miniak miniak force-pushed the disable-download-win-arm64 branch from 5193dc8 to a7dbf08 Compare April 23, 2022 23:12
@coveralls
Copy link

coveralls commented Apr 23, 2022

Coverage Status

Coverage increased (+0.004%) to 93.238% when pulling d0ecfcc on miniak:disable-download-win-arm64 into 2486d0b on electron:main.

@miniak miniak force-pushed the disable-download-win-arm64 branch 2 times, most recently from 1c37bd3 to 79ab4ee Compare April 23, 2022 23:15
@miniak miniak changed the title fix: disable downloads for Electron <6.0.8 and <7.0.0 on Windows arm64 fix: disable downloads for Electron !(>=6.0.8 || >=7.0.0) on Windows arm64 Apr 23, 2022
@miniak miniak changed the title fix: disable downloads for Electron !(>=6.0.8 || >=7.0.0) on Windows arm64 fix: disable downloads for Electron below 6.0.8 and 7.0.0 on Windows arm64 Apr 23, 2022
@miniak miniak force-pushed the disable-download-win-arm64 branch from 79ab4ee to d0ecfcc Compare April 23, 2022 23:18
@BlackHole1 BlackHole1 merged commit efcf7da into electron:main Apr 24, 2022
@miniak miniak deleted the disable-download-win-arm64 branch April 24, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants