Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to get Notifications working on Windows 10 #154

Closed
wants to merge 1 commit into from

Conversation

vviikk
Copy link

@vviikk vviikk commented Jan 8, 2019

Fixes #153

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.877% when pulling d7b58df on vviikk:patch-1 into 00cb5cf on electron:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.877% when pulling d7b58df on vviikk:patch-1 into 00cb5cf on electron:master.

@malept
Copy link
Member

malept commented Jan 8, 2019

I think it would be better to add some code and/or comments to https://github.com/electron/fiddle/blob/master/static/templates/Notification/main.js rather than increase the size of the README.

Also, doesn't this duplicate the Notification documentation (which is linked to in the notification template)?

@felixrieseberg
Copy link
Member

I agree with @malept here, I think the README of this project isn't the right place for this kind of documentation. I really appreciate your effort and am thankful, but I think we should think this over and possibly find another solution.

@vviikk
Copy link
Author

vviikk commented Jan 8, 2019

No problem. I've added this to the Electron docs as well, and the PR just got merged.

electron/electron#16320

Let me know if you need anything else. And yes, we probably need to find a workaround, or do something in electron-forge.

@vviikk vviikk closed this Jan 8, 2019
@malept
Copy link
Member

malept commented Jan 8, 2019

or do something in electron-forge.

Like add something to the default template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants