Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

fix: Always create cookie store with network context (3-1-x) #725

Merged
merged 1 commit into from Dec 3, 2018

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Dec 3, 2018

Description of Change

Backports https://crrev.com/c/1152083
Ref electron/electron#15836

Checklist
  • PR description included and stakeholders cc'd
  • Patch information is added to appropriate .patches.yaml
  • script/update runs without error
  • PR title follows semantic commit guidelines

} // namespace net

namespace network {
+class CookieManager;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the trouble now 😆

Copy link
Member

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me after looking at https://crrev.com/c/1152083 (once tests pass).

@felixrieseberg
Copy link
Member

felixrieseberg commented Dec 3, 2018

../../services/network/network_context.cc:323:12: error: member reference type 'network::URLRequestContextBuilderMojo *' is a pointer; did you mean to use '->'?
    builder.SetCookieAndChannelIdStores(std::move(cookie_store),
    ~~~~~~~^
           ->

Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@deepak1556
Copy link
Member Author

@codebytere lets merge this, the 3-1-x libcc bump will use the merge commit and these builds are useless.

@BinaryMuse BinaryMuse merged commit dfad80d into electron-3-1-x Dec 3, 2018
@deepak1556 deepak1556 deleted the cookie_store_patch branch December 3, 2018 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants