Skip to content

Commit

Permalink
build: do CFA releases (#1566)
Browse files Browse the repository at this point in the history
* build: do CFA releases

* chore: prepare for package and repo rename

* build: always pull x64 darwin build

* downgrade

---------

Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Co-authored-by: Samuel Attard <sam@electronjs.org>
  • Loading branch information
3 people committed Nov 7, 2023
1 parent b21ea52 commit 4e3ab8a
Show file tree
Hide file tree
Showing 21 changed files with 1,814 additions and 171 deletions.
13 changes: 11 additions & 2 deletions .circleci/config.yml
@@ -1,7 +1,8 @@
version: 2.1

orbs:
node: electronjs/node@1.2.0
cfa: continuousauth/npm@2.0.0
node: electronjs/node@1.4.1

jobs:
test:
Expand All @@ -21,6 +22,7 @@ jobs:
- node/test:
post-node-js-install-steps:
- run: test/ci/before_install.sh
override-ci-command: yarn install --frozen-lockfile --ignore-engines
test-steps:
- restore_cache:
name: Restoring Electron cache
Expand Down Expand Up @@ -63,4 +65,11 @@ workflows:
- 16.4.0
filters:
branches: { ignore: gh-pages }

- cfa/release:
requires:
- test
filters:
branches:
only:
- main
context: cfa-release
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug.md
Expand Up @@ -7,7 +7,7 @@ labels: "bug :bug:"
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->

* [ ] I have read the [contribution documentation](https://github.com/electron/electron-packager/blob/main/CONTRIBUTING.md) for this project.
* [ ] I have read the [contribution documentation](https://github.com/electron/packager/blob/main/CONTRIBUTING.md) for this project.
* [ ] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project follows, as appropriate.
* [ ] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Expand Up @@ -7,7 +7,7 @@ labels: "enhancement"
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->

* [ ] I have read the [contribution documentation](https://github.com/electron/electron-packager/blob/main/CONTRIBUTING.md) for this project.
* [ ] I have read the [contribution documentation](https://github.com/electron/packager/blob/main/CONTRIBUTING.md) for this project.
* [ ] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project follows, as appropriate.
* [ ] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Expand Down
6 changes: 3 additions & 3 deletions .github/config.yml
Expand Up @@ -2,9 +2,9 @@

# Comment to be posted to on first time issues
newIssueWelcomeComment: |
👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the [support docs](https://github.com/electron/electron-packager/blob/main/SUPPORT.md). If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.
👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the [support docs](https://github.com/electron/packager/blob/main/SUPPORT.md). If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the [contributing guidelines](https://github.com/electron/electron-packager/blob/main/CONTRIBUTING.md#before-opening-bug-reportstechnical-issues).
To help make it easier for us to investigate your issue, please follow the [contributing guidelines](https://github.com/electron/packager/blob/main/CONTRIBUTING.md#before-opening-bug-reportstechnical-issues).
# Configuration for new-pr-welcome - https://github.com/behaviorbot/new-pr-welcome

Expand All @@ -13,7 +13,7 @@ newPRWelcomeComment: |
Thanks for opening a pull request!
Here are some highlighted action items that will help get it across the finish line, from the
[pull request guidelines](https://github.com/electron/electron-packager/blob/main/CONTRIBUTING.md#filing-pull-requests):
[pull request guidelines](https://github.com/electron/packager/blob/main/CONTRIBUTING.md#filing-pull-requests):
- Follow the [JavaScript coding style](https://standardjs.com/).
- Run `npm run lint` locally to catch formatting errors earlier.
- Document any user-facing changes in `NEWS.md` and other docs.
Expand Down
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Expand Up @@ -3,7 +3,7 @@ Thanks for filing a pull request!
Please check off all of the steps as they are completed by replacing [ ] with [x].
-->

* [ ] I have read the [contribution documentation](https://github.com/electron/electron-packager/blob/main/CONTRIBUTING.md) for this project.
* [ ] I have read the [contribution documentation](https://github.com/electron/packager/blob/main/CONTRIBUTING.md) for this project.
* [ ] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project follows, as appropriate.
* [ ] The changes are appropriately documented (if applicable).
* [ ] The changes have sufficient test coverage (if applicable).
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/canary.yml
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Install Electron Packager
run: |
cd electron-quick-start
npm install --save-dev electron-packager@electron/electron-packager
npm install --save-dev @electron/packager@electron/packager
shell: bash
- name: Package
run: |
Expand Down
9 changes: 9 additions & 0 deletions .releaserc.json
@@ -0,0 +1,9 @@
{
"plugins": [
"@semantic-release/commit-analyzer",
"@semantic-release/release-notes-generator",
"@continuous-auth/semantic-release-npm",
"@semantic-release/github"
],
"branches": ["main"]
}
15 changes: 2 additions & 13 deletions CONTRIBUTING.md
Expand Up @@ -4,7 +4,7 @@ Electron Packager is a community-driven project. As such, we welcome and encoura
contributions. They include, but are not limited to:

- Constructive feedback
- [Questions about usage](https://github.com/electron/electron-packager/blob/main/SUPPORT.md)
- [Questions about usage](https://github.com/electron/packager/blob/main/SUPPORT.md)
- [Bug reports / technical issues](#before-opening-bug-reportstechnical-issues)
- Documentation changes
- Feature requests
Expand Down Expand Up @@ -41,7 +41,7 @@ messages when a script errors.**

## Contribution suggestions

We use the label [`help wanted`](https://github.com/electron/electron-packager/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) in the issue tracker to denote fairly-well-scoped-out bugs or feature requests that the community can pick up and work on. If any of those labeled issues do not have enough information, please feel free to ask constructive questions. (This applies to any open issue.)
We use the label [`help wanted`](https://github.com/electron/packager/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) in the issue tracker to denote fairly-well-scoped-out bugs or feature requests that the community can pick up and work on. If any of those labeled issues do not have enough information, please feel free to ask constructive questions. (This applies to any open issue.)

## Filing Pull Requests

Expand Down Expand Up @@ -124,14 +124,3 @@ existing fixture, such as `basic`. If you need to add a new fixture:
## For Collaborators

Make sure to get a `:thumbsup:`, `+1` or `LGTM` from another collaborator before merging a PR.

### Release process

- if you aren't sure if a release should happen, open an issue
- make sure that `NEWS.md` is up to date
- make sure the tests pass
- `npm version <major|minor|patch>`
- `git push && git push --tags` (or `git push` with `git config --global push.followTags true` on latest git)
- create a new GitHub release from the pushed tag with the contents of `NEWS.md` for that version
- close the milestone associated with the version if one is open
- `npm publish`

0 comments on commit 4e3ab8a

Please sign in to comment.