Merge pull request #794 from electron-userland/overwrite-with-default…

…-platform-arch

Fix overwrite when default platform/arch are used

index.js

@@ -63,6 +63,7 @@ class Packager {
   }
 
   overwriteAndCreateApp (outDir, comboOpts, zipPath) {
+    debug(`Removing ${outDir} due to setting overwrite: true`)
     return fs.remove(outDir)
       .then(() => this.createApp(comboOpts, zipPath))
   }
@@ -94,7 +95,7 @@ class Packager {
   }
 
   checkOverwrite (comboOpts, zipPath) {
-    const finalPath = common.generateFinalPath(this.opts)
+    const finalPath = common.generateFinalPath(comboOpts)
     return fs.pathExists(finalPath)
       .then(exists => {
         if (exists) {

test/basic.js

@@ -195,6 +195,21 @@ util.testSinglePlatform('overwrite test', (t, opts) => {
     .then(exists => t.false(exists, 'The output directory should be regenerated when overwrite is true'))
 })
 
+util.testSinglePlatform('overwrite test sans platform/arch set', (t, opts) => {
+  delete opts.platfrom
+  delete opts.arch
+  opts.dir = util.fixtureSubdir('basic')
+  opts.overwrite = true
+
+  return packager(opts)
+    .then(paths => fs.pathExists(paths[0]))
+    .then(exists => {
+      t.true(exists, 'The output directory exists')
+      return packager(opts)
+    }).then(paths => fs.pathExists(paths[0]))
+    .then(exists => t.true(exists, 'The output directory exists'))
+})
+
 util.testSinglePlatform('tmpdir test', (t, opts) => {
   opts.name = 'tmpdirTest'
   opts.dir = path.join(__dirname, 'fixtures', 'basic')