#831 Update node version check to support node 10 #832
Conversation
mattridley
changed the title
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 621 621
=====================================
Hits 621 621Continue to review full report at Codecov.
|
| var nodeVersionInfo = process.versions.node.split('.').map(function (n) { return Number(n) }) | ||
| if (nodeVersionInfo < [4, 0, 0]) { | ||
| var nodeMajorVersion = Number(process.versions.node.split('.')[0]) | ||
| if (nodeMajorVersion < 4) { |
There was a problem hiding this comment.
If you want to check if the version is greater than some specific semver in the future, I would require semver and use its comparison method... inequality checks on arrays convert to strings ... so [4,2,0] > [4,10,0] == true but should be false when comparing two versions.
But, if all this cares about is the major version, then this approach is sufficient.
|
There's already another PR with semver: #835 |
Update the node version check to support node 10 (#831). The current check fails once the node version hits double figures.
This PR simplifies the check to only compare the major version number.