Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid Backports being consistently marked invalid #107

Closed
codebytere opened this issue Jun 22, 2019 · 0 comments · Fixed by #108
Closed

Valid Backports being consistently marked invalid #107

codebytere opened this issue Jun 22, 2019 · 0 comments · Fixed by #108

Comments

@codebytere
Copy link
Member

codebytere commented Jun 22, 2019 •
edited

Recently, valid backports whose PR bodies contained the target text Backport of #12345 have been nondeterministically marked invalid in Trop's check suite.

They also take a notably long time to reach that conclusion.

See:
electron/electron#18898
electron/electron#18803
electron/electron#18804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: invalid backports when links are used electron/trop
1 participant
@codebytere