fix: invalid backports when links are used #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107.
We account for both links and PR numbers when searching a PR body to look for valid backports, but did not take into account that this changes which capture group is populated with the valid number.
This PR adds a truthy check to the first capture group (a PR number), and if it's
undefined
uses the second capture group's value, which must then be correct because the user pasted a link.cc @MarshallOfSound