fix: only modify backportable checks inside queue #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #283.
Applying multiple labels to a PR at the same time can cause multiple webhook events to trigger multiple runs of the same backportable checks in trop. The queue ensures there's only one in-progress at a time, but the existing code creates/updates check runs before entering the queue. Creating a new check run with the same name simply overwrites any existing ones. This situation lead to various race conditions where check runs are modified in ways which lead to an inconsistent result displayed on GitHub. Resolution is simply to only modify the check runs inside the queue (effectively a critical section) to guarantee no one else is touching them.