fix: try mark as failure without annotations when the GitHub API fails #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally this means we send invalid annotations, so let's just send a failure without them. E.g. electron/electron#15541
ckerr
approved these changes
Nov 2, 2018
There was a problem hiding this comment.
@MarshallOfSound LGTM, but I'm curious what prompted this change?
|
@ckerr The Electron PR linked in this PR, trop failed to report a failure because GitHub rejected the annotations. At least with this we'll get a failure report on GH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally this means we send invalid annotations, so let's just send a
failure without them.
E.g. electron/electron#15541