fix: Add builtins check for return type (#124)

* fix: Add builtins check for return type * export isBuiltIn
electron · Jan 30, 2019 · dc4c6e5 · dc4c6e5
1 parent 593abe2
commit dc4c6e5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/module-declaration.js b/lib/module-declaration.js
@@ -126,7 +126,7 @@ const generateModuleDeclaration = (module, index, API) => {
       returnType = moduleMethod.returns
       // Account for methods on the process module that return a custom type/structure, we need to reference the Electron namespace to use these types
       if (module.name === 'process' && moduleMethod.returns.type !== 'Object' &&
-          typeof moduleMethod.returns.type === 'string' && !utils.isPrimitive(moduleMethod.returns.type)) {
+          typeof moduleMethod.returns.type === 'string' && !utils.isPrimitive(moduleMethod.returns.type) && !utils.isBuiltIn(moduleMethod.returns.type)) {
         returnType = `Electron.${moduleMethod.returns.type}`
       }
     }

diff --git a/lib/utils.js b/lib/utils.js
@@ -150,6 +150,13 @@ const isPrimitive = (type) => {
   ]
   return primitives.indexOf(type.toLowerCase().replace(/\[\]/g, '')) !== -1
 }
+const isBuiltIn = (type) => {
+  const builtIns = [
+    'promise',
+    'buffer'
+  ]
+  return builtIns.indexOf(type.toLowerCase().replace(/\[\]/g, '')) !== -1
+}
 const isOptional = (param) => {
   // Did we pass a "required"?
   if (typeof param.required !== 'undefined') {
@@ -215,4 +222,4 @@ const genMethodString = (paramInterfaces, module, moduleMethod, parameters, retu
   }).join(', ')}${includeType ? `) => ${returns ? typify(returns) : 'void'}` : ''}`
 }
 
-module.exports = { extendArray, isEmitter, isOptional, paramify, typify, wrapComment, genMethodString, isPrimitive }
+module.exports = { extendArray, isEmitter, isOptional, paramify, typify, wrapComment, genMethodString, isPrimitive, isBuiltIn }