fix: allow primitives in NodeJS.Process modifications #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
approved these changes
Aug 10, 2018
| @@ -125,7 +125,8 @@ const generateModuleDeclaration = (module, index, API) => { | |||
| if (moduleMethod.returns) { | |||
| returnType = moduleMethod.returns | |||
| // Account for methods on the process module that return a custom type/structure, we need to reference the Electron namespace to use these types | |||
| if (module.name === 'process' && moduleMethod.returns.type !== 'Object') { | |||
| if (module.name === 'process' && moduleMethod.returns.type !== 'Object' && | |||
| typeof moduleMethod.returns.type === 'string') { | |||
There was a problem hiding this comment.
Asking for my own understanding, could you explain what this addition does wrt the Number | null documentation change?
There was a problem hiding this comment.
Previously all modifications to the process API in nodejs used complex structures as the return values. These lived in the "Electron" namespace so we blanket prefixed all the type names here so that the types were referenced correctly.
This PR adds "number" and "null" as return types which are primitives and don't exist in the electron namespace. Primitives are still type objects at this point in the code not string names. So we can just typeof check to see if we should prefix with "Electron" or not
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for: electron/electron#13542