fix: Update spellcheck API in smoketest #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll need to update the docs hash for the tests to pass https://github.com/electron/electron-typescript-definitions/blob/master/vendor/fetch-docs.jsL You can point it at your PR |
|
🤘 |
ckerr
reviewed
Sep 21, 2018
test-smoke/electron/test/renderer.ts
Outdated
| webFrame.setSpellCheckProvider('en-US', { | ||
| spellCheck (words, callback) { | ||
| setTimeout(() => { | ||
| let misspeltWords = [] |
There was a problem hiding this comment.
- nit: `misspelt' is valid but has 1/28th the Google hits as 'misspelled', and the spellchecker API uses the word 'misspelled', so let's follow the Principle of Least Surprise and use it here too
constin JS means "we won't change the address this pointer points to" rather than "this variable's value is immutable", so this can & should beconstrather thanlet
There was a problem hiding this comment.
I was actually using misspelt in the updated spellcheck API PR in electron. Changed that also.
test-smoke/electron/test/renderer.ts
Outdated
| setTimeout(() => { | ||
| let misspeltWords = [] | ||
| for (let word of words) { | ||
| if (require('spellchecker').isMisspelled(word)) { |
There was a problem hiding this comment.
require()has a nontrivial cost, so it's better to move it outside of this loop into a localconstArray.prototype.filter()would be useful here
test-smoke/electron/test/renderer.ts
Outdated
| misspeltWords.push(word) | ||
| } | ||
| } | ||
| callback(misspeltWords) |
There was a problem hiding this comment.
more concise:
const spellchecker = require('spellchecker')
const misspelled = words.filter(x => spellchecker.isMisspelled(x))
callback(misspelled)
|
Thanks for the feedback @ckerr ! 🙇 |
zeke
reviewed
Sep 23, 2018
| spellCheck (words, callback) { | ||
| setTimeout(() => { | ||
| const spellchecker = require('spellchecker') | ||
| const misspelled = words.filter(x => spellchecker.isMisspelled(x)) |
There was a problem hiding this comment.
I know misspelt is "a word", but I'm glad to see that it got refactored away. 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the spellcheck API in smoke tests.
[Corresponding electron change https://github.com/electron/electron/pull/14032]