Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move @electron/docs-parser to runtime dependencies #257

Closed
wants to merge 2 commits into from

Conversation

erickzhao
Copy link
Member

I think this is technically more correct. I noticed that npx @electron/typescript-definitions will fail due to docs-parser being a dev dependency.

> npx @electron/typescript-definitions
Need to install the following packages:
@electron/typescript-definitions@8.15.3
Ok to proceed? (y) y
node:internal/modules/cjs/loader:1080
  throw err;
  ^

Error: Cannot find module '@electron/docs-parser'
Require stack:
- /Users/erick.zhao/.npm/_npx/2a5658ae8c272926/node_modules/@electron/typescript-definitions/dist/utils.js
- /Users/erick.zhao/.npm/_npx/2a5658ae8c272926/node_modules/@electron/typescript-definitions/dist/index.js
- /Users/erick.zhao/.npm/_npx/2a5658ae8c272926/node_modules/@electron/typescript-definitions/dist/bin.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
    at Module._load (node:internal/modules/cjs/loader:922:27)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/Users/erick.zhao/.npm/_npx/2a5658ae8c272926/node_modules/@electron/typescript-definitions/dist/utils.js:6:23)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/erick.zhao/.npm/_npx/2a5658ae8c272926/node_modules/@electron/typescript-definitions/dist/utils.js',
    '/Users/erick.zhao/.npm/_npx/2a5658ae8c272926/node_modules/@electron/typescript-definitions/dist/index.js',

@erickzhao erickzhao requested review from a team as code owners February 20, 2024 19:56
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want this, it was a deliberate choice to make ts defs and docs parser separate as you don't need one for the other

@erickzhao erickzhao closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants