Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Special case ReadableStream type to mean Node.js ReadableStream #99

Merged
merged 2 commits into from Aug 13, 2018
Merged

fix: Special case ReadableStream type to mean Node.js ReadableStream #99

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57e5129
Special case ReadableStream type to mean Node.js ReadableStream
niik May 9, 2018
982f4e9
doh, typo
niik May 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/utils.js
View file
Open in desktop
Expand Up @@ -99,6 +99,12 @@ const typify = (type) => {
return 'string'
case 'touchbaritem':
return '(TouchBarButton | TouchBarColorPicker | TouchBarGroup | TouchBarLabel | TouchBarPopover | TouchBarScrubber | TouchBarSegmentedControl | TouchBarSlider | TouchBarSpacer | null)'
case 'readablestream':
// See StreamProtocolResponse.data which accepts a Node.js readable stream.
// The ReadableStream type unfortunately conflicts with the ReadableStream interface
// defined in the Streams standard (https://streams.spec.whatwg.org/#rs-class) so
// we'll have to qualify it with the Node.js namespace.
return 'NodeJS.ReadableStream'
}
// if (type.substr(0, 8) === 'TouchBar' && type !== 'TouchBar') {
// return `Electron.${type}`
Expand Down