Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #133

Merged
merged 8 commits into from May 18, 2023
Merged

Conversation

felixrieseberg
Copy link
Member

This PR aims to update our dependencies. With that come various mandatory refactors:

  • node-redis has moved to a more modern API, meaning that we have to rewrite how we call Redis. The main difference here is moving away from promisify().
  • node-fetch is no longer required as Node comes with native fetch(). Annoyingly, nock doesn't work with Node's native fetch(), so I'm keeping it around as a development dependency for testing.
  • Moved some code around to make testing things easier.

@felixrieseberg felixrieseberg requested a review from a team as a code owner May 5, 2023 00:07
bin/update-server.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/updates.js Outdated Show resolved Hide resolved
test/update.test.js Outdated Show resolved Hide resolved
felixrieseberg and others added 4 commits May 5, 2023 09:33
Co-authored-by: Black-Hole️ <github@bugs.cc>
Co-authored-by: Black-Hole️ <github@bugs.cc>
Co-authored-by: Black-Hole️ <github@bugs.cc>
@felixrieseberg felixrieseberg merged commit b4600b5 into electron:main May 18, 2023
2 checks passed
@felixrieseberg felixrieseberg mentioned this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants