Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honour EA_NO_HAVE_CPP11_TUPLES before trying to include <tuple> #443

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Honour EA_NO_HAVE_CPP11_TUPLES before trying to include <tuple> #443

wants to merge 1 commit into from

Conversation

zhmu
Copy link

@zhmu zhmu commented Oct 13, 2021

EA_COMPILER_NO_STRUCTURED_BINDING does not properly check whether can be included.

This change strengthens the condition to prevent build errors on C++17 when is not available.

@james-moran-ea
Copy link
Contributor

Hi there,
Apologies for the delay in getting back to you, we appreciate the submission. We just pushed a new CI workflow that uses github actions since our existing travis CI hasn't been running on new PRs. Could you sync down the latest changes and update this PR so that the checks run? Once those changes are made and the checks succeed, we can move forward with this :)
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhmu @james-moran-ea