Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore verification UI tests #7295

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

amitkma
Copy link
Contributor

@amitkma amitkma commented Oct 5, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Verification related UI tests are ignored. So it is necessary to not ignore them and verify the behaviour.

Motivation and context

UI tests related to verification has been ignored so it was hard to verify any behavior about session verification. This PR enables them so we can confirm that the UI changes are working as expected.
WRT -> #7197

Tests

To test this PR, run this command -> :vector-app:connectedGplayDebugAndroidTest

All instrumented tests should pass.

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11 and 12

Checklist

@amitkma amitkma marked this pull request as ready for review October 10, 2022 16:29
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work.
Just added small comments

@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bmarty
Copy link
Member

bmarty commented Jan 10, 2023

@BillCarsonFr can you handle this PR please? A test is not passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants