Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Alert verification layout text in RTL devices #8793

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Amir-yazdanmanesh
Copy link
Contributor

@Amir-yazdanmanesh Amir-yazdanmanesh commented Mar 30, 2024

Fix Alert verification layout text in RTL devices

  • Feature
  • Bugfix
  • Technical
  • Other :

Screenshots / GIFs

Before

Untitled

After

Untitled2

Tests

  • Step 1: Open the settings page.
  • Step 2: Open Preferences.
  • Step 3: Change the language to "فارسی - عربی".
  • Step 4
  • Open home page
  • Step 5
  • See top of screeen

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label May 16, 2024
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

This is not OK, the shield should be at the bottom - end corner.
I guess to properly fix this, you could create an integer in the resource that you will use for layout_constraintCircleAngle, with the default value 135 (as of now), and an alternative resource for RTL language with the value 225, in this file.

You can take the opportunity to replace all the app:layout_constraintCircleAngle="135" occurrence in the project.

Also, please add your sign-off, more information can be found here: https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants