Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable flashFrame usage on linux #1683

Merged
merged 1 commit into from
May 20, 2024

Conversation

alexcarson440
Copy link
Contributor

@alexcarson440 alexcarson440 commented May 17, 2024

Update the function that calls flashFrame when receiving a "Loud" notification so that it will execute on linux, as well as windows. This will flash the window to attract user's attention when there are new unread messages until the window is focused again. This will bring parity for behavior between the Windows and Linux desktop apps.

Fixes: #715
Type: defect

Checklist

  • Ensure your code works with manual testing.
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Signed-off-by: Alex Meridian <alex@meridian.family>
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 17, 2024
@alexcarson440 alexcarson440 reopened this May 17, 2024
@alexcarson440 alexcarson440 marked this pull request as ready for review May 17, 2024 17:06
@alexcarson440 alexcarson440 requested a review from a team as a code owner May 17, 2024 17:06
@dosubot dosubot bot added the T-Defect label May 17, 2024
@dbkr
Copy link
Member

dbkr commented May 20, 2024

Seems good, I assume the fact this this happens unconditionally on Windows means that we don't need to worry about whether the user has such features enabled or not? I also wonder why we need to explicitly check for the OS rather than just doing it anyway and it being a no-op if it's not supported.

@dbkr dbkr merged commit c49f7e6 into element-hq:develop May 20, 2024
37 of 39 checks passed
@alexcarson440
Copy link
Contributor Author

Seems good, I assume the fact this this happens unconditionally on Windows means that we don't need to worry about whether the user has such features enabled or not? I also wonder why we need to explicitly check for the OS rather than just doing it anyway and it being a no-op if it's not supported.

To be honest, I agree with this, I think there is no reason it shouldn't be called regardless of OS, but I was just following the existing logic. I can do another PR to take the OS check out if that's wanted.

I also think that there could be a setting added for this (as requested in #743), but that would take a bit more work to implement that the quick fix here.

@alexcarson440 alexcarson440 deleted the linux-flash-frame branch May 20, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop client on Linux should set "demands_attention" flag or change the icon on unread messages
2 participants