Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add captions to sent image and video files #2573

Open
jmartinesp opened this issue Mar 20, 2024 · 1 comment · May be fixed by #2600
Open

Add captions to sent image and video files #2573

jmartinesp opened this issue Mar 20, 2024 · 1 comment · May be fixed by #2600
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design

Comments

@jmartinesp
Copy link
Contributor

jmartinesp commented Mar 20, 2024 •
edited

Your use case

What would you like to do?

I want to have some UI that allows me to add captions to image or video files I'm about to send.

Now that #2521 is implemented it is possible to send both a plain text and formatted caption. It would be nice to be able to send at least the plain text version, if not both.

Why would you like to do it?

It's weird we can display captions but not send them. It's also present in most other IM apps.

How would you like to achieve it?

By implementing some new design that adds a text field to the attachment preview screen displayed before a media attachment is sent.

Have you considered any alternatives?

We could just leave it as is.

Additional context

Something similar to WhatsApp's implementation would probably be a nice fit to expand our current UI:

image

Are you willing to provide a PR?

Yes
@jmartinesp jmartinesp added S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements O-Occasional Affects or can be seen by some users regularly or most users rarely X-Needs-Design labels Mar 20, 2024
@surakin
Copy link
Contributor

surakin commented Mar 25, 2024

Hey! I've been playing with this, would you like to see what I've got? (I put the attachment preview above the composer instead of adding a new text field to the current preview view)

It currently looks like this
image

@surakin surakin linked a pull request Mar 25, 2024 that will close this issue
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move attachment preview above the composer, allowing to add captions … surakin/element-x-android
2 participants
@jmartinesp @surakin