-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move attachment preview above the composer, allowing to add captions … #2600
base: develop
Are you sure you want to change the base?
Conversation
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
Is it necessary to keep the |
I understand this is the only feedback until matrix-org/matrix-rust-sdk#1732 is sorted out |
A small bug I noticed today: Trying to send a captioned image as a reply sends okay, but doesn't attach the reply metadata to the event and leaves the reply box in the composer |
Hmmm sending replies with anything other than text is not supported yet anyway |
In what sense? I have seen many users (especially beeper users) send images in reply to messages and they get rendered in EXA just fine, is there a limitation on the Rust-SDK's end maybe? 🤔 |
Yes, afaik the rust SDK can only reply with text so far. |
…to media/attachments Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
…attachments is supported Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
…sibility of pressing it multiple times Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
651a652
to
c4b5a92
Compare
…captions # Conflicts: # features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesFlowNode.kt # features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesNode.kt # features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesView.kt # features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/attachments/preview/AttachmentsPreviewView.kt # features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/AttachmentsBottomSheet.kt # features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/MessageComposerView.kt # features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/typing/MessagesViewWithTypingPreview.kt # libraries/textcomposer/impl/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt
Signed-off-by: Marco Antonio Alvarez <surakin@gmail.com>
…to media/attachments
Fixes #2573
I has too many UX changes for my taste so if one of the team likes it and wants to pick it up that's fine by me :)
Type of change
Content
Motivation and context
Screenshots / GIFs
Before sending
After sending
Tests
Tested devices
Checklist