Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin sonarqube to v5 #2606

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 26, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.sonarqube 4.4.1.3373 -> 5.0.0.4638 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner March 26, 2024 10:54
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Mar 26, 2024
@renovate renovate bot requested review from ganfra and removed request for a team March 26, 2024 10:54
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.58%. Comparing base (b4b07d8) to head (35e9e7e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2606   +/-   ##
========================================
  Coverage    75.58%   75.58%           
========================================
  Files         1576     1576           
  Lines        37345    37345           
  Branches      7260     7260           
========================================
  Hits         28228    28228           
  Misses        5321     5321           
  Partials      3796     3796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp
Copy link
Contributor

jmartinesp commented Apr 2, 2024

I ran some tests in https://github.com/element-hq/element-x-android/tree/test/jme/sonar-5 and it seems like there are 2 issues causing the sonar task to fail:

  1. The testFixtures gradle setting is not compatible with Sonar, apparently, so we need to disable it.
  2. We need to set sonar.gradle.skipCompile to true and run ./gradlew lintDebug sonar in the CI.

That seems to make it work again from my results in https://github.com/element-hq/element-x-android/actions/runs/8525250062.

Manually generating the fixtures for the sonar job seems to fix the issue (see this commit).

@renovate renovate bot force-pushed the renovate/org.sonarqube-5.x branch from 1de6c96 to c7dd7bc Compare April 21, 2024 07:28
@ElementBot
Copy link
Collaborator

ElementBot commented Apr 21, 2024

Warnings
⚠️

gradle/libs.versions.toml#L12 - A newer version of androidx.core:core-ktx than 1.13.0 is available: 1.13.1

⚠️

gradle/libs.versions.toml#L18 - A newer version of androidx.datastore:datastore-preferences than 1.0.0 is available: 1.1.1

⚠️

gradle/libs.versions.toml#L21 - A newer version of androidx.lifecycle:lifecycle-runtime-ktx than 2.7.0 is available: 2.8.1

⚠️

gradle/libs.versions.toml#L22 - A newer version of androidx.activity:activity-compose than 1.8.2 is available: 1.9.0

⚠️

gradle/libs.versions.toml#L24 - A newer version of androidx.camera:camera-view than 1.3.2 is available: 1.3.3

⚠️

gradle/libs.versions.toml#L213 - A newer version of androidx.appcompat:appcompat than 1.6.1 is available: 1.7.0

Generated by 🚫 dangerJS against 35e9e7e

Copy link
Contributor

github-actions bot commented Apr 21, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/M3LbTG

@renovate renovate bot force-pushed the renovate/org.sonarqube-5.x branch from 28e0266 to 35e9e7e Compare May 31, 2024 15:19
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants