Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellcheck to quality checks #2781

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Conversation

hughns
Copy link
Member

@hughns hughns commented May 1, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Copy link
Contributor

github-actions bot commented May 1, 2024

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • There is a changelog entry in the changelog.d folder with the Towncrier format.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@hughns hughns mentioned this pull request May 1, 2024
14 tasks
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.41%. Comparing base (e9c262e) to head (6c1fb4f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2781   +/-   ##
========================================
  Coverage    73.41%   73.41%           
========================================
  Files         1523     1523           
  Lines        36528    36528           
  Branches      7038     7038           
========================================
  Hits         26816    26816           
  Misses        6043     6043           
  Partials      3669     3669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty
Copy link
Member

bmarty commented Jun 4, 2024

Thanks for starting to work on this @hughns, do you intend to finish it? Else please let me know, I can do it.

@hughns
Copy link
Member Author

hughns commented Jun 5, 2024

@bmarty I don't have any plans to progress this at the moment. So, if you can take it over then great 👍 thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants