-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK API break: replace getRoomPreview
by getRoomPreviewFromRoomId
.
#2868
Conversation
We do not need `getRoomPreviewFromRoomAlias` since we always resolve the Alias first.
|
7b8c921
to
bc46706
Compare
Closes #2833 |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2868 +/- ##
========================================
Coverage 74.30% 74.30%
========================================
Files 1530 1530
Lines 36524 36524
Branches 7054 7054
========================================
Hits 27140 27140
Misses 5698 5698
Partials 3686 3686 ☔ View full report in Codecov by Sentry. |
Replace
getRoomPreview
bygetRoomPreviewFromRoomId
.We do not need
getRoomPreviewFromRoomAlias
since we always resolve the Alias first.Draft as it need a SDK release.