Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK API break: replace getRoomPreview by getRoomPreviewFromRoomId. #2868

Merged
merged 3 commits into from
May 20, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 17, 2024

Replace getRoomPreview by getRoomPreviewFromRoomId.
We do not need getRoomPreviewFromRoomAlias since we always resolve the Alias first.

Draft as it need a SDK release.

We do not need `getRoomPreviewFromRoomAlias` since we always resolve the Alias first.
@ElementBot
Copy link
Collaborator

ElementBot commented May 17, 2024

Warnings
⚠️

gradle/libs.versions.toml#L12 - A newer version of androidx.core:core-ktx than 1.13.0 is available: 1.13.1

⚠️

gradle/libs.versions.toml#L18 - A newer version of androidx.datastore:datastore-preferences than 1.0.0 is available: 1.1.1

⚠️

gradle/libs.versions.toml#L21 - A newer version of androidx.lifecycle:lifecycle-runtime-ktx than 2.7.0 is available: 2.8.0

⚠️

gradle/libs.versions.toml#L22 - A newer version of androidx.activity:activity-compose than 1.8.2 is available: 1.9.0

Messages
📖

gradle/libs.versions.toml#L136 - There are multiple dependencies junit:junit but with different version

📖

gradle/libs.versions.toml#L138 - There are multiple dependencies androidx.test.ext:junit but with different version

📖

gradle/libs.versions.toml#L207 - There are multiple dependencies junit:junit but with different version

📖

gradle/libs.versions.toml#L208 - There are multiple dependencies androidx.test.ext:junit but with different version

Generated by 🚫 dangerJS against b784746

@ganfra ganfra marked this pull request as ready for review May 20, 2024 15:51
@ganfra ganfra requested a review from a team as a code owner May 20, 2024 15:51
@ganfra ganfra requested review from jmartinesp and removed request for a team May 20, 2024 15:51
@ganfra
Copy link
Contributor

ganfra commented May 20, 2024

Closes #2833

@ganfra ganfra enabled auto-merge May 20, 2024 15:52
Copy link
Contributor

github-actions bot commented May 20, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Dx9Vf8

Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.30%. Comparing base (4919cd6) to head (b784746).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2868   +/-   ##
========================================
  Coverage    74.30%   74.30%           
========================================
  Files         1530     1530           
  Lines        36524    36524           
  Branches      7054     7054           
========================================
  Hits         27140    27140           
  Misses        5698     5698           
  Partials      3686     3686           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 20, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 20, 2024
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 20, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label May 20, 2024
@ganfra ganfra merged commit 5d8cc80 into develop May 20, 2024
27 of 28 checks passed
@ganfra ganfra deleted the feature/bma/upgradeSdk branch May 20, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants