-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dpendencies update + improved dependencies version management #721
Conversation
Generated by 🚫 Danger Swift against 817c080 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #721 +/- ##
========================================
Coverage 52.17% 52.17%
========================================
Files 277 277
Lines 14983 14983
Branches 9260 9260
========================================
Hits 7818 7818
Misses 6937 6937
Partials 228 228
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting an error when running swift run tools setup-project
on this branch. Apparently
Computed https://github.com/apple/swift-argument-parser at 1.2.2 (0.00s)
error: Couldn’t check out revision ‘f47ba4838c30dbd59998a4e4c87ab620ff959e8a’:
fatal: reference is not a tree: f47ba4838c30dbd59998a4e4c87ab620ff959e8a
Not sure how to fix it, any idea what this is about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also take this opportunity to fix the typo in echo "warning: Sourcert not installed
?
I also want to start a discussion around whether we should actually run this step on every build or make it part of the tools.
Happened to me too solved this by using in this order swift package resolve I had the same issue, is likely there an SPM bug that happens in repo Package.swift managed manually |
We actually already had a discussion with @pixlwave and @alfogrillo and Sourcery takes essentially only 0.5 seconds to run as part of the run phase script, so it's not big deal to have a separate tool for now. Maybe if we are going to have TONS of protocols mocked could be worth it, but for now is already blazingly fast |
Alrighty, fair enough 👍 |
Doesn't work for me unfortunately. Does it work on your side @pixlwave ? |
Try also: Otherwise this is a bit drastic but you could try to delete the ~/Library/Caches/org.swift.swiftpm/repositories and search for the folder of the argument parser and delete it, and try running the resolve command again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, 🚢 it! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! 👏
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
NOTE:
I had to set an exactVersion as 1.6.26 for DTCoreText, because a tag for a version 1.6.27 exists but is not in the official release list (there are no release notes for it in fact), and creates some flaky behaviours with block quotes.