Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dpendencies update + improved dependencies version management #721

Merged
merged 14 commits into from
Mar 23, 2023

Conversation

Velin92
Copy link
Contributor

@Velin92 Velin92 commented Mar 22, 2023

  • Updated the dependencies
  • Forced minor versions in the project.yml for dependencies
  • Added a tool that allows to check for outdated dependencies in the project

NOTE:
I had to set an exactVersion as 1.6.26 for DTCoreText, because a tag for a version 1.6.27 exists but is not in the official release list (there are no release notes for it in fact), and creates some flaky behaviours with block quotes.

@Velin92 Velin92 requested a review from a team as a code owner March 22, 2023 14:56
@Velin92 Velin92 requested review from stefanceriu and removed request for a team March 22, 2023 14:56
@github-actions
Copy link

github-actions bot commented Mar 22, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 817c080

@Velin92 Velin92 changed the title Updating Dependencies Updating Dependencies and forcing minor versions Mar 22, 2023
@Velin92 Velin92 changed the title Updating Dependencies and forcing minor versions Dpendencies update + improved dependencies version management Mar 22, 2023
@Velin92 Velin92 requested a review from pixlwave March 22, 2023 18:06
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (e696280) 52.17% compared to head (b6b54ed) 52.17%.

❗ Current head b6b54ed differs from pull request most recent head 817c080. Consider uploading reports for the commit 817c080 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #721   +/-   ##
========================================
  Coverage    52.17%   52.17%           
========================================
  Files          277      277           
  Lines        14983    14983           
  Branches      9260     9260           
========================================
  Hits          7818     7818           
  Misses        6937     6937           
  Partials       228      228           
Flag Coverage Δ
unittests 21.75% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ElementX/Sources/Other/Logging/MXLog.swift 75.34% <33.33%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting an error when running swift run tools setup-project on this branch. Apparently

Computed https://github.com/apple/swift-argument-parser at 1.2.2 (0.00s)
error: Couldn’t check out revision ‘f47ba4838c30dbd59998a4e4c87ab620ff959e8a’:
    fatal: reference is not a tree: f47ba4838c30dbd59998a4e4c87ab620ff959e8a

Not sure how to fix it, any idea what this is about?

Tools/Sources/Tools.swift Show resolved Hide resolved
Package.resolved Show resolved Hide resolved
Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also take this opportunity to fix the typo in echo "warning: Sourcert not installed?

I also want to start a discussion around whether we should actually run this step on every build or make it part of the tools.

@Velin92
Copy link
Contributor Author

Velin92 commented Mar 23, 2023

I'm getting an error when running swift run tools setup-project on this branch. Apparently

Computed https://github.com/apple/swift-argument-parser at 1.2.2 (0.00s)
error: Couldn’t check out revision ‘f47ba4838c30dbd59998a4e4c87ab620ff959e8a’:
    fatal: reference is not a tree: f47ba4838c30dbd59998a4e4c87ab620ff959e8a

Not sure how to fix it, any idea what this is about?

Happened to me too solved this by using in this order

swift package resolve
swift package update (actually this is maybe optional)
swift package resolve

I had the same issue, is likely there an SPM bug that happens in repo Package.swift managed manually
apple/swift-argument-parser#517

@Velin92
Copy link
Contributor Author

Velin92 commented Mar 23, 2023

Should we also take this opportunity to fix the typo in echo "warning: Sourcert not installed?

I also want to start a discussion around whether we should actually run this step on every build or make it part of the tools.

We actually already had a discussion with @pixlwave and @alfogrillo and Sourcery takes essentially only 0.5 seconds to run as part of the run phase script, so it's not big deal to have a separate tool for now. Maybe if we are going to have TONS of protocols mocked could be worth it, but for now is already blazingly fast

@stefanceriu
Copy link
Contributor

but for now is already blazingly fast

Alrighty, fair enough 👍

@stefanceriu
Copy link
Contributor

swift package resolve

Doesn't work for me unfortunately. Does it work on your side @pixlwave ?

@Velin92
Copy link
Contributor Author

Velin92 commented Mar 23, 2023

swift package resolve

Doesn't work for me unfortunately. Does it work on your side @pixlwave ?

Try also:
swift package reset && swift package resolve

Otherwise this is a bit drastic but you could try to delete the ~/Library/Caches/org.swift.swiftpm/repositories and search for the folder of the argument parser and delete it, and try running the resolve command again.

Package.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, 🚢 it! 👏

Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 👏

Velin92 and others added 3 commits March 23, 2023 11:14
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
@Velin92 Velin92 enabled auto-merge (squash) March 23, 2023 10:17
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Velin92 Velin92 disabled auto-merge March 23, 2023 10:26
@Velin92 Velin92 merged commit ca319e0 into develop Mar 23, 2023
@Velin92 Velin92 deleted the mauroromito/update_package_dependencies_1 branch March 23, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants