Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uploadRoomKeysToBackup: Use V3 route #1161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NicolaiSoeborg
Copy link

@NicolaiSoeborg NicolaiSoeborg commented Jan 28, 2024

Fixes #741

"Tested" locally by rewriting r0 to v3 in reverse proxy (Caddy) and seeing All keys are backed up. instead of repeated failing PUT requests towards Conduit (home server)

matrix.example.com {
    # this will make Hydrogen and Conduit happy together,
    # but it shouldn't be the responsibility of the reverse proxy:
    rewrite /_matrix/client/r0/room_keys/keys /_matrix/client/v3/room_keys/keys?{query}

    reverse_proxy /_matrix/* localhost:8448
}

Fixes element-hq#741

"Tested" locally by rewriting `r0` to `v3` in reverse proxy (Caddy) and seeing `All keys are backed up.` instead of repeated failing PUT requests towards Conduit (home server)

```
matrix.example.com {
    rewrite /_matrix/client/r0/room_keys/keys /_matrix/client/v3/room_keys/keys?{query}
    reverse_proxy /_matrix/* localhost:8448
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PUT /_matrix/client/r0/room_keys/keys is used, while it was never specced.
1 participant