Add more HTML form and SVG elements #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split off from #653 Personally using `select`, `option`, and `path` currently in https://github.com/matrix-org/matrix-public-archive but added a few extra SVG elements that seemed common to me.
MadLittleMods
commented
Feb 25, 2022
| "pre", "code", "button", "time", "input", "textarea", "label", "form", "progress", "output", "video"], | ||
| [SVG_NS]: ["svg", "circle"] | ||
| "pre", "code", "button", "time", "input", "textarea", "select", "option", "label", "form", | ||
| "progress", "output", "video"], |
There was a problem hiding this comment.
The diff isn't obvious here but I just added "select", "option" to this list and put the others on a new line.
bwindels
approved these changes
Mar 1, 2022
|
Thanks for the review and merge @bwindels 🦦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more HTML form and SVG elements
Split off from #653
Personally using
select,option, andpathcurrently in https://github.com/matrix-org/matrix-public-archivebut added a few extra SVG elements that seemed common to me.