Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the SDK friendly to locally link and develop on #693

Merged

Commits on Feb 26, 2022

  1. Make the SDK friendly to locally link and develop on

    Fix #686
    Fix #682
    
    Instead of deleting the whole `target/` directory, leave it alone so the symlink
    driving the `npm link`/`yarn link` stays in tact.
    
    Leave Vite builds in their build directories (`/lib-build`/`/asset-build`)
    so you can `vite build --watch` to build on local changes and still have a
    consisent place to reference in the `package.json` `exports`. Previously,
    everything relied on `build.sh` which does a bunch of moving and renaming
    and made it hard to rebuild on changes.
    
    Add back support for CommonJS (adding the `package.json` `exports`).
    
    The last piece is making sure the `?url` imports (`import workerPath from 'hydrogen-view-sdk/main.js?url';`)
    work still. It looks like this may have just been solved via
    vitejs/vite#6725 -> vitejs/vite#7073
    (literally 2 days ago) and we just need to wait for the next Vite release 🎉
    MadLittleMods committed Feb 26, 2022
    Configuration menu
    Copy the full SHA
    cd007b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8fb2b27 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0023ab3 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Merge branch 'master' into madlittlemods/686-682-local-friendly-devel…

    …opment-and-commonjs
    
    Conflicts:
    	package.json
    	scripts/sdk/base-manifest.json
    MadLittleMods committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    d247bc4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    95d1730 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dd06d78 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Configuration menu
    Copy the full SHA
    2401b7f View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Merge branch 'master' into madlittlemods/686-682-local-friendly-devel…

    …opment-and-commonjs
    
    Conflicts:
    	package.json
    	scripts/sdk/base-manifest.json
    	scripts/sdk/build.sh
    MadLittleMods committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    12d6447 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f61bf60 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Configuration menu
    Copy the full SHA
    f56dc58 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into madlittlemods/686-682-local-friendly-devel…

    …opment-and-commonjs
    
    Conflicts:
    	scripts/sdk/build.sh
    MadLittleMods committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    e9cee2e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f1e07b6 View commit details
    Browse the repository at this point in the history
  4. Remove extra space

    MadLittleMods committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    ce289ba View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Update Vite to avoid flakey errors in our PostCSS plugins

    Fix #722
    
    Updating Vite to includes fixes from
    vitejs/vite#7822 -> vitejs/vite#7827
    MadLittleMods committed May 5, 2022
    Configuration menu
    Copy the full SHA
    d053d43 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    75098b4 View commit details
    Browse the repository at this point in the history
  3. Add some comments

    MadLittleMods committed May 5, 2022
    Configuration menu
    Copy the full SHA
    e54482e View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Merge branch 'master' into madlittlemods/686-682-local-friendly-devel…

    …opment-and-commonjs
    
    Conflicts:
    	scripts/sdk/base-manifest.json
    MadLittleMods committed May 12, 2022
    Configuration menu
    Copy the full SHA
    639358b View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Configuration menu
    Copy the full SHA
    b725269 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. Configuration menu
    Copy the full SHA
    1b2a6b5 View commit details
    Browse the repository at this point in the history