New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the SDK friendly to locally link and develop on #693
Make the SDK friendly to locally link and develop on #693
Commits on Feb 26, 2022
-
Make the SDK friendly to locally link and develop on
Fix #686 Fix #682 Instead of deleting the whole `target/` directory, leave it alone so the symlink driving the `npm link`/`yarn link` stays in tact. Leave Vite builds in their build directories (`/lib-build`/`/asset-build`) so you can `vite build --watch` to build on local changes and still have a consisent place to reference in the `package.json` `exports`. Previously, everything relied on `build.sh` which does a bunch of moving and renaming and made it hard to rebuild on changes. Add back support for CommonJS (adding the `package.json` `exports`). The last piece is making sure the `?url` imports (`import workerPath from 'hydrogen-view-sdk/main.js?url';`) work still. It looks like this may have just been solved via vitejs/vite#6725 -> vitejs/vite#7073 (literally 2 days ago) and we just need to wait for the next Vite release 🎉
Configuration menu - View commit details
-
Copy full SHA for cd007b4 - Browse repository at this point
Copy the full SHA cd007b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fb2b27 - Browse repository at this point
Copy the full SHA 8fb2b27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0023ab3 - Browse repository at this point
Copy the full SHA 0023ab3View commit details
Commits on Apr 5, 2022
-
Merge branch 'master' into madlittlemods/686-682-local-friendly-devel…
…opment-and-commonjs Conflicts: package.json scripts/sdk/base-manifest.json
Configuration menu - View commit details
-
Copy full SHA for d247bc4 - Browse repository at this point
Copy the full SHA d247bc4View commit details -
Update Vite which includes fixes to importing
*.js?url
withexports
Update to Vite which includes vitejs/vite#7098
Configuration menu - View commit details
-
Copy full SHA for 95d1730 - Browse repository at this point
Copy the full SHA 95d1730View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd06d78 - Browse repository at this point
Copy the full SHA dd06d78View commit details
Commits on Apr 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2401b7f - Browse repository at this point
Copy the full SHA 2401b7fView commit details
Commits on Apr 19, 2022
-
Merge branch 'master' into madlittlemods/686-682-local-friendly-devel…
…opment-and-commonjs Conflicts: package.json scripts/sdk/base-manifest.json scripts/sdk/build.sh
Configuration menu - View commit details
-
Copy full SHA for 12d6447 - Browse repository at this point
Copy the full SHA 12d6447View commit details -
Configuration menu - View commit details
-
Copy full SHA for f61bf60 - Browse repository at this point
Copy the full SHA f61bf60View commit details
Commits on Apr 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f56dc58 - Browse repository at this point
Copy the full SHA f56dc58View commit details -
Merge branch 'master' into madlittlemods/686-682-local-friendly-devel…
…opment-and-commonjs Conflicts: scripts/sdk/build.sh
Configuration menu - View commit details
-
Copy full SHA for e9cee2e - Browse repository at this point
Copy the full SHA e9cee2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1e07b6 - Browse repository at this point
Copy the full SHA f1e07b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce289ba - Browse repository at this point
Copy the full SHA ce289baView commit details
Commits on May 5, 2022
-
Update Vite to avoid flakey errors in our PostCSS plugins
Fix #722 Updating Vite to includes fixes from vitejs/vite#7822 -> vitejs/vite#7827
Configuration menu - View commit details
-
Copy full SHA for d053d43 - Browse repository at this point
Copy the full SHA d053d43View commit details -
Merge branch 'master' into madlittlemods/686-682-local-friendly-devel…
…opment-and-commonjs
Configuration menu - View commit details
-
Copy full SHA for 75098b4 - Browse repository at this point
Copy the full SHA 75098b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e54482e - Browse repository at this point
Copy the full SHA e54482eView commit details
Commits on May 12, 2022
-
Merge branch 'master' into madlittlemods/686-682-local-friendly-devel…
…opment-and-commonjs Conflicts: scripts/sdk/base-manifest.json
Configuration menu - View commit details
-
Copy full SHA for 639358b - Browse repository at this point
Copy the full SHA 639358bView commit details
Commits on May 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b725269 - Browse repository at this point
Copy the full SHA b725269View commit details
Commits on May 30, 2022
-
Merge branch 'master' into madlittlemods/686-682-local-friendly-devel…
…opment-and-commonjs
Configuration menu - View commit details
-
Copy full SHA for 1b2a6b5 - Browse repository at this point
Copy the full SHA 1b2a6b5View commit details