Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import SDK assets from the assets/ directory #746

Merged
merged 4 commits into from Jul 4, 2022
Merged

Import SDK assets from the assets/ directory #746

merged 4 commits into from Jul 4, 2022

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented May 31, 2022 •
edited

Import SDK assets from the assets/ directory

Will be easier towards the future when adding more assets. Probably best to keep style.css for now for backwards compat though.

-- @bwindels, #693 (comment)

$ yarn test:sdk
...
SDK works in Vite build ✅
SDK works in CommonJS ✅

@MadLittleMods
Import assets from the assets/ directory
38c3774 
> Will be easier towards the future when adding more assets. Probably best to keep style.css for now for backwards compat though.
>
> *-- #693 (comment)
@MadLittleMods MadLittleMods mentioned this pull request May 31, 2022
Merged
bwindels
bwindels approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

scripts/sdk/base-manifest.json Outdated Show resolved Hide resolved
@bwindels bwindels merged commit fba3275 into master Jul 4, 2022
@MadLittleMods
Copy link
Contributor Author

Thanks for the review and merge @bwindels 🐒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwindels bwindels Awaiting requested review from bwindels

Assignees
No one assigned
Labels
maintenance sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MadLittleMods @bwindels