Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling with the main log in view #817

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Kaki-In
Copy link
Contributor

@Kaki-In Kaki-In commented Jul 26, 2022

Scrolling on the main log view

Technical changes :

  • made the body scrolling, for the PreSessionScreen to overflow him and be scrolled;
  • Verified that it doesn't make issues for the main screen (when connected).

Should fix this issue (783)

Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, need to look more into it. For now just a comment with an idea to simplify.


@media screen and (min-width: 600px) {
.PreSessionScreen {
max-height: calc(100% - 30px - 80px); /* removing padding and margin */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea, but would this be simpler if we use box-sizing: content-box?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ^^'

Copy link
Contributor Author

@Kaki-In Kaki-In Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't work because of the margin, I still need to had the @media.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Continue as..." screen to pick session doesn't scroll when you have many sessions signed in
2 participants