Add a way to toggle scrollToBottom so you can start scroll from the top as well and continue reading
#915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…op as well and continue reading See `?continue=top` in matrix-org/matrix-viewer#114 for how this is used
MadLittleMods
commented
Nov 2, 2022
Comment on lines
+73
to
+76
| constructor(vm: TimelineViewModel, { | ||
| viewClassForTile, | ||
| stickToBottom = true | ||
| }: TimelineViewOpts) { |
There was a problem hiding this comment.
I've made this an options object because I forsee more options here (see future notes in PR description)
MadLittleMods
commented
Nov 3, 2022
| @@ -57,16 +57,27 @@ function findFirstNodeIndexAtOrBelow(tiles: HTMLElement, top: number, startIndex | |||
| return 0; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Closing (alternative incoming)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to toggle
scrollToBottomso you can start scroll from the top as well and continue reading.Split out from #653
See
?continue=topin matrix-org/matrix-viewer#114 for how this is specifically used. When jumping to the next page of activity, you want to start from the top to continue reading where you left off.Future notes
For Matrix Public Archive we want:
?at=$xxxmatrix-org/matrix-viewer#4Potential alternatives
Add a way to disable all scroll controls from Hydrogen itself and have the downstream API consumer control everything.
I could see Hydrogen supporting most of those scroll behaviors though (except scrolled to top).