Fix deduplicating of membership events to not create unused state groups. #17164
+54
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We try and deduplicate in two places: 1) really early on, and 2) just before we persist the event. The first case was broken due to it occuring before the profile information was added, and so it thought the event contents were different. The second case did catch it and handle it correctly, however doing so creates a redundant state group leading to bloat.
devonh
reviewed
May 14, 2024
|
This line in the synapse/synapse/handlers/message.py Line 597 in 68dca80 |
anoadragon453
approved these changes
May 29, 2024
synapse/handlers/room_member.py
Outdated
| @@ -106,6 +106,13 @@ def __init__(self, hs: "HomeServer"): | |||
| self.event_auth_handler = hs.get_event_auth_handler() | |||
| self._worker_lock_handler = hs.get_worker_locks_handler() | |||
|
|
|||
| self.membership_types_to_include_profile_data_in = { | |||
There was a problem hiding this comment.
nit: self.membership_types_to_include_profile_data_in should have a leading underscore.
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
H-Shay
pushed a commit
to H-Shay/hq_synapse
that referenced
this pull request
May 31, 2024
…ups. (element-hq#17164) We try and deduplicate in two places: 1) really early on, and 2) just before we persist the event. The first case was broken due to it occuring before the profile information was added, and so it thought the event contents were different. The second case did catch it and handle it correctly, however doing so creates a redundant state group leading to bloat. Fixes element-hq#3791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try and deduplicate in two places: 1) really early on, and 2) just before we persist the event. The first case was broken due to it occuring before the profile information was added, and so it thought the event contents were different.
The second case did catch it and handle it correctly, however doing so creates a redundant state group leading to bloat.
Fixes #3791